Fix 210 to skip non-number values #69
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fix rule 210 to skip non-number values (e.g. `000-default`) as they
aren't octal values but strings.
This commit also allows optional whitespace around the unquoted octal
value, and the value followed by a YAML or JINJA comment (e.g.
`0700 {# JINJA COMMENT #}`).
Fixes #68.
Signed-off-by: Roald Nefs <info@roaldnefs.com>
jbouter
approved these changes
Oct 21, 2019
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix rule 210 to skip unquoted non-number values (e.g.
000-default) as they aren't octal values but strings.This commit also allows optional whitespace around the unquoted octal value, and the value followed by a YAML or JINJA comment (e.g.
0700 {# JINJA COMMENT #}).Fixes #68.